forked from benirose/O_C-BenisphereSuite
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relabi branch rebased on Phazerville #2
Open
djphazer
wants to merge
432
commits into
TricksterSam:production
Choose a base branch
from
djphazer:relabi-phz
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shoutout to Chris Meyer for the great idea! Features per channel: * Voltage scaling in 0.01% increments * DAC Bias offset in 1/128th semitone * Input quantization, Scale & Root Note selection * Transpose adjustment in Octaves and Scale Degrees * Clocked transpose mode * S&H mode * 4x instances w/ separate configs (presets hack) - Single instance for the main build
enabled with build flag ENABLE_APP_PIQUED
this was never a very good idea, lol
Trig stays high for default Clock duration, then decays. Transpose is now V/Oct, sampled when clocked. ...and some refactoring of my laziness
Ideal for generating two CV sequences + two trigger patterns or 4 trigger patterns... ;)
with 4 separate multipliers. Also tweaked BugCrack so it can be internally clocked.
Enables actions to fire immediately when pressing a button, instead of when you release it. Existing functionality for BUTTON_PRESS and BUTTON_LONG_PRESS works the same. I tried to fix all naive event.type assumptions in legacy apps. Hemisphere applets now use the new event type, which might be weird in some cases, but we're gonna try it!
Shares the ClockManager and ClockSetup applet with Hemispheres. Some refactoring was necessary.
Clock Setup uses button-down for more immediacy. Regular Applets still use button-release because it gets complicated otherwise. At least the framework is there for both actions.
Long-press DOWN button goes to Clock Setup (for now)
Values are swapped on load / save
printf does not handle floats when using TEENSY_OPT_SMALLEST_CODE
words words words
+ Don't apply shuffle to MIDI Clock out
...to tolerate swing on incoming clocks; fixed
let's pretend it worked the first time
O_C-BenisphereSuite revised Runglr adjusted to include XOR of last bit and Gate. Out2 is XOR value. Works well as a Benjolin when combined with a triangle and square wave into clock1 and CV1 respectively.
Updates to objects. Relabi now has proper cross-modulation scaling. Calculate defaults to sample and hold for personal use. Clock Divider has a wider range. hemisphere_config.h reduces the number of available apps for personal use. Before uploading, user should comment and uncomment apps in hemisphere_config.h to their preference.
Clock(n) only returns true on the rising edge of a trigger/gate, so no need to cache & compare it. Alternatively, the Gate(n) function reflects current high / low state.
I've added 4 commits with routine cleanup type stuff. I hope I interpreted your logic correctly - it seems like you were overthinking the Reset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rebasing on Benisphere, I was then able to rebase on my main branch. Haven't actually tested it yet...
Same story here, you don't necessarily need to merge this PR, but here it is for you to try.